Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] bug fix for ishttpcontent not set properly #3888

Merged

Conversation

dan-drl
Copy link
Contributor

@dan-drl dan-drl commented Sep 14, 2019

PR checklist

  • Read the contribution guidelines.
  • [] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

@wangzw @ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

To fix #3886

@etherealjoy
Copy link
Contributor

@dan-drl
The generated samples did not change?

@etherealjoy
Copy link
Contributor

No change in samples.

@etherealjoy etherealjoy merged commit 0ea1ead into OpenAPITools:master Sep 20, 2019
@etherealjoy etherealjoy added this to the 4.1.3 milestone Sep 20, 2019
@wing328 wing328 changed the title Fix 3886 ishttpcontent not set ishttpcontent not set Oct 4, 2019
@wing328 wing328 changed the title ishttpcontent not set [C++] bug fix for ishttpcontent not set properly Oct 4, 2019
@wing328
Copy link
Member

wing328 commented Oct 4, 2019

@dan-drl thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++][cpp-restsdk][BUG] Templating variable x-codegen-response-ishttpcontent not being set correctly
3 participants